[ https://issues.apache.org/jira/browse/ZOOKEEPER-2779?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16002945#comment-16002945 ]
Hadoop QA commented on ZOOKEEPER-2779: -------------------------------------- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 7 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/674//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/674//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/674//console This message is automatically generated. > Add option to not set ACL for reconfig node > ------------------------------------------- > > Key: ZOOKEEPER-2779 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2779 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Affects Versions: 3.5.3 > Reporter: Jordan Zimmerman > Assignee: Jordan Zimmerman > Fix For: 3.5.4, 3.6.0 > > > ZOOKEEPER-2014 changed the behavior of the /zookeeper/config node by setting > the ACL to {{ZooDefs.Ids.READ_ACL_UNSAFE}}. This change makes it very > cumbersome to use the reconfig APIs. It also, perversely, makes security > worse as the entire ZooKeeper instance must be opened to "super" user while > enabled reconfig (per {{ReconfigExceptionTest.java}}). Provide a mechanism > for savvy users to disable this ACL so that an application-specific custom > ACL can be set. -- This message was sent by Atlassian JIRA (v6.3.15#6346)