Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/254#discussion_r116570478
  
    --- Diff: src/java/main/org/apache/zookeeper/ClientCnxn.java ---
    @@ -1080,6 +1080,8 @@ private void startConnect() throws IOException {
                             zooKeeperSaslClient.shutdown();
                         }
                         zooKeeperSaslClient = new 
ZooKeeperSaslClient(getServerPrincipal(addr), clientConfig);
    +                    // SASL login succeeded
    +                    saslLoginFailed = false;
    --- End diff --
    
    I wonder if this will impact `clientTunneledAuthenticationInProgress`? 
Perhaps we should revert this when a new connection attempt starts?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to