Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/173#discussion_r116799126
--- Diff: src/java/main/org/apache/zookeeper/server/quorum/QuorumPeer.java
---
@@ -117,13 +117,21 @@ private QuorumServer(long id, InetSocketAddress addr,
this.id = id;
this.addr = addr;
this.electionAddr = electionAddr;
+ String ipReachableValue =
System.getProperty("zookeeper.ipReachableTimeout");
--- End diff --
This code is duplicated four times, not good :) - you can pull this into a
dedicated function instead. Also make sure to add try catch around the parseInt
to prevent crash against illegal input values.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
