[
https://issues.apache.org/jira/browse/ZOOKEEPER-2784?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16016915#comment-16016915
]
ASF GitHub Bot commented on ZOOKEEPER-2784:
-------------------------------------------
Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117406260
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -660,6 +665,9 @@ public void run() {
"Ignoring exception", ie);
}
closeSocket(client);
+ } catch (ConfigException ce) {
+ LOG.error(ce.getMessage());
+ throw new RuntimeException(ce);
--- End diff --
You are right. Throwing 'RuntimeException' does skip the closing
`ServerSocket` part, so I moved it to the end of the` run` method.
> Add some limitations on code level for `SID` to avoid configuration problem
> ---------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2784
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2784
> Project: ZooKeeper
> Issue Type: Improvement
> Components: quorum
> Affects Versions: 3.5.2
> Reporter: Benedict Jin
> Fix For: 3.6.0
>
> Original Estimate: 168h
> Remaining Estimate: 168h
>
> As so far, `QuorumCnxManager#receiveConnection` cannot find out the same
> `SID` problem, then the Zookeeper cluster will start successfully. But the
> cluster is not health, and it will throw some problem like `not
> synchronized`. So, i thought we should add some limitations on code level for
> `SID` to find those configuration problem more early.
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
