Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117574653
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -371,6 +372,10 @@ public void receiveConnection(Socket sock) {
connectOne(sid);
}
+ }else if (sid == self.getId()) {
+ closeSocket(sock);
+ throw new ConfigException(String.format("Appearing duplicate
SID: %s", sid));
--- End diff --
I think this message could be more descriptive or reshaped. English is not
my 1st language, but what about _"Inconsistent ensemble setup: duplicate SID %s
found"?_
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
