Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/257#discussion_r117600729
--- Diff:
src/java/main/org/apache/zookeeper/server/quorum/QuorumCnxManager.java ---
@@ -310,8 +311,8 @@ public boolean initiateConnection(Socket sock, Long
sid) {
* possible long value to lose the challenge.
*
*/
- public void receiveConnection(Socket sock) {
- Long sid = null, protocolVersion = null;
+ public void receiveConnection(Socket sock) throws ConfigException {
+ Long sid, protocolVersion;
--- End diff --
Yes, integers whose values are between -127 and 128 (inclusive) are cached
inside Integer object.
Plus, boxing/unboxing in a tight loop (not the case here!) can be a huge
performance pitfall. For example:
```
for (Integer it = 0; it < 10000; ){
it += 1;
}
```
Used to have abysmal performance numbers due to many auto boxing/unboxing .
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
