[jira] [Commented] (ZOOKEEPER-2788) The define of MAX_CONNECTION_ATTEMPTS in QuorumCnxManager.java seems useless, should it be removed?

[Abraham Fine (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2788?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16030071#comment-16030071
 ] 

Abraham Fine commented on ZOOKEEPER-2788:
-----------------------------------------

[~jiangjiafu]-

You appear to be correct and it does not appear that we ever used it.

{code}
$ git log -S MAX_CONNECTION_ATTEMPTS
commit d56cc9b9acb453945257a8e3b0cf8d88e5a36d35
Author: Flavio Paiva Junqueira <f...@apache.org>
Date:   Wed Mar 5 14:12:22 2008 +0000

    Leader election patch.
    
    git-svn-id: https://svn.apache.org/repos/asf/hadoop/zookeeper/trunk@670901 
13f79535-47bb-0310-9956-ffa450edef68
{code}

I submitted a PR to have this removed.

> The define of MAX_CONNECTION_ATTEMPTS in QuorumCnxManager.java seems useless, 
> should it be removed?
> ---------------------------------------------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2788
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2788
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: leaderElection, quorum
>    Affects Versions: 3.4.10, 3.5.3, 3.4.11
>            Reporter: JiangJiafu
>            Priority: Minor
>
> The define of MAX_CONNECTION_ATTEMPTS in QuorumCnxManager.java seems useless, 
> should it be removed?



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)