Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/271#discussion_r119967195
--- Diff: src/java/test/org/apache/zookeeper/test/ClientBase.java ---
@@ -100,6 +100,8 @@ public void process(WatchedEvent event) { /* nada */ }
volatile boolean connected;
// Set to true when connected to a quorum server.
volatile boolean syncConnected;
+ // Set to true when connected to a quorum server in read-only mode
+ volatile boolean readOnlyConnected;
--- End diff --
One nit : now there are three variables that encode the connection state
and three waitForxxxConnected functions. These could be refactored so we use a
single variable and a parameterized function to encode the state and state
changes.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
