[
https://issues.apache.org/jira/browse/ZOOKEEPER-2798?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16035592#comment-16035592
]
ASF GitHub Bot commented on ZOOKEEPER-2798:
-------------------------------------------
Github user hanm commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/271#discussion_r119967195
--- Diff: src/java/test/org/apache/zookeeper/test/ClientBase.java ---
@@ -100,6 +100,8 @@ public void process(WatchedEvent event) { /* nada */ }
volatile boolean connected;
// Set to true when connected to a quorum server.
volatile boolean syncConnected;
+ // Set to true when connected to a quorum server in read-only mode
+ volatile boolean readOnlyConnected;
--- End diff --
One nit : now there are three variables that encode the connection state
and three waitForxxxConnected functions. These could be refactored so we use a
single variable and a parameterized function to encode the state and state
changes.
> Fix flaky test:
> org.apache.zookeeper.test.ReadOnlyModeTest.testConnectionEvents
> -------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2798
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2798
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.4.10, 3.5.3
> Reporter: Abraham Fine
> Assignee: Abraham Fine
>
> This test appears to be failing intermitently on both 3.4 and 3.5. Here are a
> couple of example failing jobs.
> 3.4: https://builds.apache.org/job/ZooKeeper_branch34_jdk7/1404/
> 3.5: https://builds.apache.org/job/ZooKeeper_branch35_jdk8/459/
--
This message was sent by Atlassian JIRA
(v6.3.15#6346)
