Github user jainbhupendra24 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/279#discussion_r121658390
--- Diff:
src/java/main/org/apache/zookeeper/server/PrepRequestProcessor.java ---
@@ -915,11 +915,13 @@ protected void pRequest(Request request) throws
RequestProcessorException {
private List<ACL> removeDuplicates(List<ACL> acl) {
ArrayList<ACL> retval = new ArrayList<ACL>();
- Iterator<ACL> it = acl.iterator();
- while (it.hasNext()) {
- ACL a = it.next();
- if (retval.contains(a) == false) {
- retval.add(a);
+ if(acl != null) {
--- End diff --
Server side, the validation for null is already present in fixupACL method
and it throws InvalidACLException. This check is after the removeDuplicates
method call.
So do you mean we can handle null in removeDuplicates method itself and if
so,, we can remove the null validation code in fixupACL method.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
