[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1782?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16058373#comment-16058373
 ] 

ASF GitHub Bot commented on ZOOKEEPER-1782:
-------------------------------------------

Github user hanm commented on the issue:

    https://github.com/apache/zookeeper/pull/282
  
    One more thing here. Looks like we don't have an existing configuration 
option or system property called "superUser" (or zookeeper.superUser). So this 
`zookeeper.superUser` should be documented.
    
    The existing approach of how superuser is defined under various auth 
provider:
    * For digest, it's `zookeeper.DigestAuthenticationProvider.superDigest`.
    * For ssl, it's `zookeeper.X509AuthenticationProvider.superUser`.
    
    So maybe for SASL we name it 
`zookeeper.SASLAuthenticationProvider.superUser`, rather than 
`zookeeper.superUser` given it's only applicable to SASL?


> zookeeper.superUser is not as super as superDigest
> --------------------------------------------------
>
>                 Key: ZOOKEEPER-1782
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1782
>             Project: ZooKeeper
>          Issue Type: Bug
>    Affects Versions: 3.4.5
>            Reporter: Robert Joseph Evans
>            Assignee: Robert Joseph Evans
>         Attachments: zk-1782.patch, zk-1782.patch
>
>
> The zookeeper.superUser system property does not fully grant super user 
> privileges, like zookeeper.DigestAuthenticationProvider.superDigest does.
> zookeeper.superUser only has as many privileges as the sasl ACLs on the znode 
> being accessed.  This means that if a znode only has digest ACLs 
> zookeeper.superUser is ignored.  Or if a znode has a single sasl ACL that 
> only has read privileges zookeeper.superUser only has read privileges.
> The reason for this is that SASLAuthenticationProvider implements the 
> superUser check in the matches method, instead of having the super user 
> include a new Id("super","") as Digest does.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to