Github user asdf2014 commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/297#discussion_r124721264
--- Diff:
src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java ---
@@ -590,14 +590,13 @@ public boolean
clientTunneledAuthenticationInProgress() {
// authentication is either in progress, successful, or
failed.
// 1. Authentication hasn't finished yet: we must wait for
it to do so.
- if ((isComplete() == false) &&
- (isFailed() == false)) {
+ if ((!isComplete()) && (!isFailed())) {
return true;
}
// 2. SASL authentication has succeeded or failed..
if (isComplete() || isFailed()) {
--- End diff --
Hi, @shralex. Yep, if we get the value of `!isComplete()` is `true`, then
we already know the authentication has not yet been completed, so it should
return `true` for the `clientTunneledAuthenticationInProgress` method directly.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
