Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r127117526
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -430,6 +432,7 @@ public void processRequest(Request request) {
// the client and leader disagree on where the client is most
// recently attached (and therefore invalid SESSION MOVED
generated)
cnxn.sendCloseSession();
+ request.checkLatency();
--- End diff --
On a related note, besides logging those slow requests, wouldn't be nice to
expose a counter of how many requests were above the latency threshold and
store it in `zks.serverStats()` so that it could be exposed as metric via JMX?
Going even further, we could expose other metrics related to slow requests
like average time & 99% percentiles as suggested by @tdunning
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
