[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2859?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102360#comment-16102360
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2859:
-------------------------------------------

GitHub user andschwa opened a pull request:

    https://github.com/apache/zookeeper/pull/319

    ZOOKEEPER-2859: Fix CMake build on OS X.

    And take care of a TODO for pthread.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/andschwa/zookeeper macos

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/zookeeper/pull/319.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #319
    
----
commit 050ece633b3a9eec70db139a7e95bc70015cb6ab
Author: Andrew Schwartzmeyer <and...@schwartzmeyer.com>
Date:   2017-07-26T22:01:40Z

    ZOOKEEPER-2859: Fix CMake build on OS X.
    
    And take care of a TODO for pthread.

----


> CMake build doesn't support OS X
> --------------------------------
>
>                 Key: ZOOKEEPER-2859
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2859
>             Project: ZooKeeper
>          Issue Type: Bug
>         Environment: OS X 10.12.6
>            Reporter: Andrew Schwartzmeyer
>            Assignee: Andrew Schwartzmeyer
>
> Couple problems:
> libm, librt, and libdl are all Linux specific, and provided "for free" on OS X
> CppUnit (at least on OS X) needs `-std=c++11`
> clang's ld doesn't understand --wrap
> I can post an easy patch that at least lets you build the client (but not the 
> tests). The tests use that `--wrap` and it's non trivial to fix that on OS X.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to