[
https://issues.apache.org/jira/browse/ZOOKEEPER-2856?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16102514#comment-16102514
]
ASF GitHub Bot commented on ZOOKEEPER-2856:
-------------------------------------------
Github user hanm commented on the issue:
https://github.com/apache/zookeeper/pull/318
LGTM. The failed test is a known issue and will be fixed by
https://github.com/apache/zookeeper/pull/315.
Merging.
> ZooKeeperSaslClient#respondToServer should log exception message of
> SaslException
> ---------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2856
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2856
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.4.10, 3.5.3
> Reporter: Pan Yuxuan
> Assignee: Pan Yuxuan
> Priority: Minor
> Attachments: ZOOKEEPER-2856-1.patch
>
>
> When upstream like HBase call ZooKeeperSaslClient with security enabled, we
> sometimes get error in HBase logs like:
> {noformat}
> SASL authentication failed using login context 'Client'.
> {noformat}
> This error occures when getting SaslException in
> ZooKeeperSaslClient#respondToServer :
> {noformat}
> catch (SaslException e) {
> LOG.error("SASL authentication failed using login context '" +
> this.getLoginContext() + "'.");
> saslState = SaslState.FAILED;
> gotLastPacket = true;
> }
> {noformat}
> This error makes user confused without explicit exception message. So I think
> we can add exception message to the log.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
