Github user eribeiro commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/307#discussion_r131282046
--- Diff:
src/java/main/org/apache/zookeeper/server/FinalRequestProcessor.java ---
@@ -460,11 +465,20 @@ public void processRequest(Request request) {
if (request.type == OpCode.closeSession) {
cnxn.sendCloseSession();
}
+ checkLatency(request);
} catch (IOException e) {
LOG.error("FIXMSG",e);
}
}
+ private void checkLatency(Request request) {
+ long requestLatency = Time.currentElapsedTime() -
request.createTime;
+ if((requestWarnThresholdMs > -1 && requestLatency >
requestWarnThresholdMs) || requestWarnThresholdMs == 0) {
+ LOG.warn("Request " + request + " exceeded threshold. Took "
+ requestLatency + " ms.");
--- End diff --
You can leverage the use of interpolation of Strings in logging:
```
LOG.warn("Request {} exceeded {}", obj1, obj2);
```
Again, such a minor suggestion that it's up to you adopt it or not. Cheers!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---
