[ https://issues.apache.org/jira/browse/ZOOKEEPER-2870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16122251#comment-16122251 ]
ASF GitHub Bot commented on ZOOKEEPER-2870: ------------------------------------------- Github user asfgit closed the pull request at: https://github.com/apache/zookeeper/pull/331 > Improve the efficiency of AtomicFileOutputStream > ------------------------------------------------ > > Key: ZOOKEEPER-2870 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2870 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Affects Versions: 3.4.10, 3.5.3, 3.6.0 > Reporter: Fangmin Lv > Assignee: Fangmin Lv > > The AtomicFileOutputStream extends from FilterOutputStream, where the write > function writes data to underlying stream byte by byte: > https://searchcode.com/codesearch/view/17990706/, which is very inefficient. > Currently, we only this this class to write the dynamic config, because it's > quite small it won't be a big problem. But in the future we may want to use > this class to write the snapshot file, which will take much longer time, > tested inside, writing 600MB snapshot will take more than 10 minutes, while > using FileOutputStream directly only takes 6s. -- This message was sent by Atlassian JIRA (v6.4.14#64029)