Michael Han created ZOOKEEPER-2876:
--------------------------------------
Summary: Github pull request test script should output -1 when
there is no tests provided in patch, unless the subject under test is a
documentation JIRA
Key: ZOOKEEPER-2876
URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2876
Project: ZooKeeper
Issue Type: Bug
Components: build-infrastructure, tests
Reporter: Michael Han
The github pull request test script (which is invoked as part of pre-commit
workflow) should output -1 on a patch which does not include any tests, unless
the patch is a documentation only patch.
We had this expected behavior before when we use the old PATCH approach:
{noformat}
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
{noformat}
A quick look on the
[script|https://github.com/apache/zookeeper/blob/master/src/java/test/bin/test-github-pr.sh#L224]
indicates that we do not set up the $PATCH/jira directory in the github test
pull script, so it always thinks incoming pull request is a documentation only
patch. This should be fixed so we get the old behavior and enforce that any new
pull request must have tests unless explicitly justified not have to.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
