[
https://issues.apache.org/jira/browse/ZOOKEEPER-2879?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16135594#comment-16135594
]
Hadoop QA commented on ZOOKEEPER-2879:
--------------------------------------
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/950//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/950//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/950//console
This message is automatically generated.
> Adding observers dynamically without server id
> ----------------------------------------------
>
> Key: ZOOKEEPER-2879
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2879
> Project: ZooKeeper
> Issue Type: Improvement
> Components: quorum
> Affects Versions: 3.6.0
> Reporter: Fangmin Lv
> Assignee: Fangmin Lv
>
> Dynamic config requires observer has unique server id, which means we cannot
> simply add observer with dynamic server id -1. For large observer cluster,
> it's much more easier to add observer without unique server id if it doesn't
> need to be promoted to participant. Also, it will make dynamic config more
> efficient, we don't need to store and send the long list of observers during
> re-config.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
