[
https://issues.apache.org/jira/browse/ZOOKEEPER-2630?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16149503#comment-16149503
]
ASF GitHub Bot commented on ZOOKEEPER-2630:
-------------------------------------------
Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/354#discussion_r136431051
--- Diff: src/java/main/org/apache/jute/compiler/JRecord.java ---
@@ -21,9 +21,7 @@
import java.io.File;
import java.io.FileWriter;
import java.io.IOException;
-import java.util.ArrayList;
-import java.util.HashMap;
-import java.util.Iterator;
+import java.util.*;
--- End diff --
we generally avoid using * inputs
> Use interface type instead of implementation type when appropriate.
> -------------------------------------------------------------------
>
> Key: ZOOKEEPER-2630
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2630
> Project: ZooKeeper
> Issue Type: Improvement
> Reporter: Michael Han
> Assignee: Tamas Penzes
> Priority: Trivial
> Labels: newbie, refactoring
>
> There are a couple of places in code base where we declare a field / variable
> as implementation type (i.e. HashMap, HashSet) instead of interface type
> (i.e. Map, Set), while in other places we do the opposite by declaring as
> interface type. A quick check indicates that most if not all of these places
> could be updated so we have a consistent style over the code base (prefer
> using interface type), which is also a good coding style to stick per best
> practice.
> See more info on https://github.com/apache/zookeeper/pull/102
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
