[
https://issues.apache.org/jira/browse/ZOOKEEPER-2572?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16152083#comment-16152083
]
ASF GitHub Bot commented on ZOOKEEPER-2572:
-------------------------------------------
Github user bitgaoshu commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/356#discussion_r136739423
--- Diff:
src/java/main/org/apache/zookeeper/server/persistence/FileTxnLog.java ---
@@ -399,18 +403,20 @@ public boolean truncate(long zxid) throws IOException
{
}
long pos = input.getPosition();
// now, truncate at the current position
- RandomAccessFile raf=new RandomAccessFile(itr.logFile,"rw");
+ raf = new RandomAccessFile(itr.logFile, "rw");
raf.setLength(pos);
- raf.close();
while(itr.goToNextLog()) {
- if (!itr.logFile.delete()) {
- LOG.warn("Unable to truncate {}", itr.logFile);
+ try {
+ Files.delete(itr.logFile.toPath());
+ } catch (NoSuchFileException e) {
}
}
--- End diff --
- i think ```Files.delete``` can provide more detailed messages if delete
operation failed. I'm not sure this change is necessary or not.
- update
> Potential resource leak in FileTxnLog.truncate
> ----------------------------------------------
>
> Key: ZOOKEEPER-2572
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2572
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.4.9, 3.5.2
> Reporter: Michael Han
> Assignee: gaoshu
> Fix For: 3.5.4, 3.6.0, 3.4.11
>
>
> In FileTxnLog.truncate, we have:
> {code}
> public boolean truncate(long zxid) throws IOException {
> FileTxnIterator itr = null;
> try {
> itr = new FileTxnIterator(this.logDir, zxid);
> PositionInputStream input = itr.inputStream;
> if(input == null) {
> throw new IOException("No log files found to truncate! This
> could " +
> "happen if you still have snapshots from an old setup
> or " +
> "log files were deleted accidentally or dataLogDir
> was changed in zoo.cfg.");
> }
> long pos = input.getPosition();
> // now, truncate at the current position
> RandomAccessFile raf=new RandomAccessFile(itr.logFile,"rw");
> raf.setLength(pos);
> raf.close();
> while(itr.goToNextLog()) {
> if (!itr.logFile.delete()) {
> LOG.warn("Unable to truncate {}", itr.logFile);
> }
> }
> } finally {
> close(itr);
> }
> return true;
> }
> {code}
> {{raf}} here can be potentially in a state of not closed after leaving the
> method, if there is an (IO) exception thrown from setLength.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
