[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-1260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16161935#comment-16161935
 ] 

ASF GitHub Bot commented on ZOOKEEPER-1260:
-------------------------------------------

Github user hanm commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/338#discussion_r138179709
  
    --- Diff: conf/log4j.properties ---
    @@ -63,3 +63,20 @@ 
log4j.appender.TRACEFILE.File=${zookeeper.tracelog.dir}/${zookeeper.tracelog.fil
     log4j.appender.TRACEFILE.layout=org.apache.log4j.PatternLayout
     ### Notice we are including log4j's NDC here (%x)
     log4j.appender.TRACEFILE.layout.ConversionPattern=%d{ISO8601} 
[myid:%X{myid}] - %-5p [%t:%C{1}@%L][%x] - %m%n
    +#
    +# zk audit logging
    +#
    +zookeeper.auditlog.file=zookeeper_audit.log
    +zookeeper.auditlog.threshold=INFO
    +audit.logger=INFO, AUDITFILE
    +log4j.logger.org.apache.zookeeper.audit.ZKAuditLogger=${audit.logger}
    +log4j.additivity.org.apache.zookeeper.audit.ZKAuditLogger=false
    --- End diff --
    
    I think something like this would be better here (see how HDFS defines 
audit log properties for example).
    log4j.additivity.org.apache.zookeeper.audit = false
    or
    log4j.additivity.org.apache.zookeeper.audit.enabled = false


> Audit logging in ZooKeeper servers.
> -----------------------------------
>
>                 Key: ZOOKEEPER-1260
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1260
>             Project: ZooKeeper
>          Issue Type: New Feature
>          Components: server
>            Reporter: Mahadev konar
>            Assignee: Mohammad Arshad
>             Fix For: 3.5.4, 3.6.0
>
>         Attachments: ZOOKEEPER-1260-01.patch, zookeeperAuditLogs.pdf
>
>
> Lots of users have had questions on debugging which client changed what znode 
> and what updates went through a znode. We should add audit logging as in 
> Hadoop (look at Namenode Audit logging) to log which client changed what in 
> the zookeeper servers. This could just be a log4j audit logger.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to