[ https://issues.apache.org/jira/browse/ZOOKEEPER-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16174792#comment-16174792 ]
Jordan Zimmerman edited comment on ZOOKEEPER-2901 at 9/21/17 1:57 PM: ---------------------------------------------------------------------- [~mjohnson207] - I think that can work. The hard part is deciding what to do about existing sessions when the new server loads. I think the only choice is to somehow invalidate those sessions. We need to do this because of this code in LeaderSessionTracker.java - which I don't understand TBH {code} /* * if local session is not enabled or it used to be our local session * throw sessions expires */ if (!localSessionsEnabled || (getServerIdFromSessionId(sessionId) == serverId)) { throw new SessionExpiredException(); } {code} It's the only place in the code where the ServerId from the session ID is used. was (Author: randgalt): [~mjohnson207] - I think that can work. The hard part is deciding what to do about existing sessions when the new server loads. I think the only choice is to somehow invalidate those sessions. We need to do this because of this code in LeaderSessionTracker.java - which I don't understand TBH {code} /* * if local session is not enabled or it used to be our local session * throw sessions expires */ if (!localSessionsEnabled || (getServerIdFromSessionId(sessionId) == serverId)) { throw new SessionExpiredException(); } {code} > Session ID that is negative causes mis-calculation of Ephemeral Type > -------------------------------------------------------------------- > > Key: ZOOKEEPER-2901 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2901 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.5.3 > Environment: Running 3.5.3-beta in Docker container > Reporter: Mark Johnson > Assignee: Jordan Zimmerman > Priority: Blocker > > In the code that determines the EphemeralType it is looking at the owner > (which is the client ID or connection ID): > EphemeralType.java: > public static EphemeralType get(long ephemeralOwner) { > if (ephemeralOwner == CONTAINER_EPHEMERAL_OWNER) { > return CONTAINER; > } > if (ephemeralOwner < 0) { > return TTL; > } > return (ephemeralOwner == 0) ? VOID : NORMAL; > } > However my connection ID is: > header.getClientId(): -720548323429908480 > This causes the code to think this is a TTL Ephemeral node instead of a > NORMAL Ephemeral node. > This also explains why this is random - if my client ID is non-negative > then the node gets added correctly. -- This message was sent by Atlassian JIRA (v6.4.14#64029)