[ https://issues.apache.org/jira/browse/ZOOKEEPER-2901?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181681#comment-16181681 ]
ASF GitHub Bot commented on ZOOKEEPER-2901: ------------------------------------------- Github user afine commented on a diff in the pull request: https://github.com/apache/zookeeper/pull/377#discussion_r141200124 --- Diff: src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java --- @@ -84,6 +84,9 @@ public static long initializeNextSession(long id) { long nextSid; nextSid = (Time.currentElapsedTime() << 24) >>> 8; nextSid = nextSid | (id <<56); + if (nextSid == EphemeralType.CONTAINER_EPHEMERAL_OWNER) { + ++nextSid; // this is an unlikely edge case, but check it just in case --- End diff -- This makes me nervous but I can't think of a reason why it wont work. It may be worth changing the comment on this method because it is no longer strictly true. > Session ID that is negative causes mis-calculation of Ephemeral Type > -------------------------------------------------------------------- > > Key: ZOOKEEPER-2901 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2901 > Project: ZooKeeper > Issue Type: Bug > Components: server > Affects Versions: 3.5.3 > Environment: Running 3.5.3-beta in Docker container > Reporter: Mark Johnson > Assignee: Jordan Zimmerman > Priority: Blocker > > In the code that determines the EphemeralType it is looking at the owner > (which is the client ID or connection ID): > EphemeralType.java: > public static EphemeralType get(long ephemeralOwner) { > if (ephemeralOwner == CONTAINER_EPHEMERAL_OWNER) { > return CONTAINER; > } > if (ephemeralOwner < 0) { > return TTL; > } > return (ephemeralOwner == 0) ? VOID : NORMAL; > } > However my connection ID is: > header.getClientId(): -720548323429908480 > This causes the code to think this is a TTL Ephemeral node instead of a > NORMAL Ephemeral node. > This also explains why this is random - if my client ID is non-negative > then the node gets added correctly. -- This message was sent by Atlassian JIRA (v6.4.14#64029)