[
https://issues.apache.org/jira/browse/ZOOKEEPER-2921?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16211155#comment-16211155
]
Patrick Hunt commented on ZOOKEEPER-2921:
-----------------------------------------
I would not reuse.
Another thing to keep in mind - the metrics already capture min/max/avg request
latency on the server. Capturing this indication in the log can be useful to
get insight after the fact, however you should already be monitoring these
metrics and could get this information in the current releases.
> fsyncWarningThresholdMS is applied on each getChannel().force() - also needed
> on entire commit
> ----------------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-2921
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2921
> Project: ZooKeeper
> Issue Type: Improvement
> Components: server
> Affects Versions: 3.5.3
> Reporter: Jordan Zimmerman
> Priority: Minor
>
> FileTxnLog.commit() has a warning when an individual sync takes longer than
> {{fsyncWarningThresholdMS}}. However, it would also be useful to warn when
> the entire commit operation takes longer than {{fsyncWarningThresholdMS}} as
> this can cause client connection failures. Currently, commit() can take
> longer than 2/3 of a session but still not log a warning.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
