[ https://issues.apache.org/jira/browse/ZOOKEEPER-2923?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16220265#comment-16220265 ]
ASF GitHub Bot commented on ZOOKEEPER-2923: ------------------------------------------- GitHub user JiangJiafu opened a pull request: https://github.com/apache/zookeeper/pull/408 ZOOKEEPER-2923 You can merge this pull request into a Git repository by running: $ git pull https://github.com/JiangJiafu/zookeeper ZOOKEEPER-2923 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/zookeeper/pull/408.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #408 ---- commit b6eb491d7dd1bd8a4db93813bb62c6abf4efe31e Author: Jiafu Jiang <jiangjiafu1...@gmail.com> Date: 2017-10-26T10:05:05Z ZOOKEEPER-2923 ---- > The comment of the variable matchSyncs in class CommitProcessor has a mistake. > ------------------------------------------------------------------------------ > > Key: ZOOKEEPER-2923 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2923 > Project: ZooKeeper > Issue Type: Bug > Components: quorum > Affects Versions: 3.4.10, 3.5.3 > Reporter: Jiafu Jiang > Priority: Minor > > The comment of the variable matchSyncs in class CommitProcessor says: > {code:java} > /** > * This flag indicates whether we need to wait for a response to come > back from the > * leader or we just let the sync operation flow through like a read. The > flag will > * be true if the CommitProcessor is in a Leader pipeline. > */ > boolean matchSyncs; > {code} > I search the source code and find that matchSyncs will be false if the > CommitProcessor is in a Leader pipeline, and it will be true if the > CommitProcessor is in a Follower pipeline. > Therefore I think the comment should be modified to match the code. -- This message was sent by Atlassian JIRA (v6.4.14#64029)