[ https://issues.apache.org/jira/browse/ZOOKEEPER-2932?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16240335#comment-16240335 ]
Hadoop QA commented on ZOOKEEPER-2932: -------------------------------------- -1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +0 tests included. The patch appears to be a documentation patch that doesn't require tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. -1 core tests. The patch failed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1158//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1158//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1158//console This message is automatically generated. > Performance enhancement about purging task > ------------------------------------------ > > Key: ZOOKEEPER-2932 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2932 > Project: ZooKeeper > Issue Type: Improvement > Components: server > Reporter: OuYang Liang > Original Estimate: 24h > Remaining Estimate: 24h > > The method FileTxnLog.getLogFiles is used to find out the target log files to > be retained base on the given zxid when purging task is running. The current > implementation of this method is trivial to understand, and iterate the log > files twice to achieve its purchase. It could be improved from both > performance and readability. -- This message was sent by Atlassian JIRA (v6.4.14#64029)