With three binding +1, two non-binding +1 (thanks Abe & Andor!) this vote passes. I will complete the release steps.
Thanks everyone, Patrick On Tue, Nov 7, 2017 at 4:54 PM, Michael Han <h...@apache.org> wrote: > I don't think this release note issue is a blocker, and I am +1 on the RC1. > > On Tue, Nov 7, 2017 at 11:31 PM, Patrick Hunt <ph...@apache.org> wrote: > > > On Mon, Nov 6, 2017 at 5:41 PM, Michael Han <h...@apache.org> wrote: > > > > > One minor issue on release note - ZOOKEEPER-2829 should be included. I > > > think it's missing in release note because the "Fixed Version" field > was > > > not set on that JIRA issue. > > > > > > Other than this, I am +1. > > > > > > > > I updated JIRA directly however unless we cut a new RC the release notes > > won't be updated. Are you ok (+1) with going forward as it currently is? > Or > > are you saying it needs to be addressed (new rc) in order to be +1. fwiw > > this happens occasionally given it not being automated and human error, > in > > the past we've handled it in this way. > > > > Regards, > > > > Patrick > > > > > > > Verified with JDK 1.8.0_151 on OS X 10.12.6 > > > > > > - Check sum and signature verified. > > > - API documentations looks good. > > > - All unit tests passed. > > > - Set up 3 node cluster, verified through zk commands and a couple of > > 4lw. > > > > > > > > > On Tue, Nov 7, 2017 at 1:43 AM, Rakesh Radhakrishnan < > rake...@apache.org > > > > > > wrote: > > > > > > > Thanks for making the release. > > > > > > > > Here is my +1. > > > > > > > > Verified using jdk 1.8.0_111 and CentOS 7.3.1611 env > > > > > > > > - checked previously reported cases of 'readme.md' and rc tag, looks > > > good. > > > > - xsum/sig verified. > > > > - release note looks good. > > > > - setup a small 3 node cluster. > > > > - ran command line zk client - create & delete set of child znodes, > get > > > > data, set data znode. > > > > - ran few 4lw commands. > > > > - ran unit test, looks good. > > > > > > > > > > > > Rakesh > > > > > > > > On Mon, Nov 6, 2017 at 10:48 PM, Patrick Hunt <ph...@apache.org> > > wrote: > > > > > > > > > I ran a number of tests in addition to what's documented on the > > cwiki. > > > > > Including bringing up ensembles of various sizes. All seemed fine > to > > > me. > > > > > > > > > > I'm +1. > > > > > > > > > > Patrick > > > > > > > > > > On Fri, Nov 3, 2017 at 2:10 PM, Abraham Fine <af...@apache.org> > > wrote: > > > > > > > > > > > +1 (non-binding) > > > > > > > > > > > > - Verified signatures and xsums for tarball and jar > > > > > > - Successfully compiled and ran the tests (using java > 1.8.0_152-ea) > > > > > > - Checked the documentation > > > > > > - Spun up 3 node cluster > > > > > > > > > > > > On Fri, Nov 3, 2017, at 09:50, Andor Molnar wrote: > > > > > > > Sent too early. > > > > > > > > > > > > > > - also verified JMX beans > > > > > > > > > > > > > > On Fri, Nov 3, 2017 at 5:50 PM, Andor Molnar < > an...@cloudera.com > > > > > > > > wrote: > > > > > > > > > > > > > > > Hi Pat, > > > > > > > > > > > > > > > > I've done verification with JDK 1.7.0_141 on my mac desktop: > > > > > > > > > > > > > > > > - signatures verified. > > > > > > > > - started a few different cluster sizes(1,3,5). > > > > > > > > - ran command line zk client - create, delete, get data, set > > data > > > > > > znode. > > > > > > > > - ran few 4lw commands. > > > > > > > > - ran unit test, looks good. > > > > > > > > > > > > > > > > Not sure if it's a problem, but md5/sha1 signature files in > > > > > dist-maven > > > > > > > > folder contain only the hash, but not filename. I was unable > to > > > > > verify > > > > > > them > > > > > > > > with standard md5sum/sha1sum commands. > > > > > > > > > > > > > > > > Regards, > > > > > > > > Andor > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On Wed, Nov 1, 2017 at 8:14 PM, Patrick Hunt < > ph...@apache.org > > > > > > > > wrote: > > > > > > > > > > > > > > > >> This is a bugfix release candidate for 3.4.11. It fixes 53 > > > issues. > > > > > > > >> > > > > > > > >> The full release notes is available at: > > > > > > > >> https://issues.apache.org/jira/secure/ReleaseNote.jspa? > > > > > > > >> projectId=12310801&version=12339207 > > > > > > > >> > > > > > > > >> *** Please download, test and vote by November 6th 2017, > 23:59 > > > > > UTC+0. > > > > > > *** > > > > > > > >> > > > > > > > >> Source files: > > > > > > > >> *https://people.apache.org/~phunt/zookeeper-3.4.11- > > > candidate-1/* > > > > > > > >> <https://people.apache.org/~phunt/zookeeper-3.4.11- > > candidate-1/ > > > > > > > > > > > >> > > > > > > > >> Maven staging repo: > > > > > > > >> https://repository.apache.org/content/groups/staging/org/ > > > > > > > >> apache/zookeeper/zookeeper/3.4.11/ > > > > > > > >> > > > > > > > >> The release candidate tag in git to be voted upon: > > > > > release-3.4.11-rc1 > > > > > > > >> > > > > > > > >> ZooKeeper's KEYS file containing PGP keys we use to sign the > > > > > release: > > > > > > > >> http://www.apache.org/dist/zookeeper/KEYS > > > > > > > >> > > > > > > > >> Should we release this candidate? > > > > > > > >> > > > > > > > >> Regards, > > > > > > > >> > > > > > > > >> Patrick > > > > > > > >> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
