[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2933?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16244979#comment-16244979
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2933:
-------------------------------------------

Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/415#discussion_r149829950
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
    @@ -984,8 +990,6 @@ public void commitAndActivate(long zxid, long 
designatedLeader) {
     
         /**
          * Create an inform packet and send it to all observers.
    -     * @param zxid
    -     * @param proposal
    --- End diff --
    
    Not that it adds much value, but why does this line need to be removed?


> Ability to monitor the jute.maxBuffer usage in real-time
> --------------------------------------------------------
>
>                 Key: ZOOKEEPER-2933
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2933
>             Project: ZooKeeper
>          Issue Type: New Feature
>          Components: jute, server
>            Reporter: Andor Molnar
>            Assignee: Andor Molnar
>              Labels: buffer, buffer-length
>             Fix For: 3.5.4, 3.6.0
>
>
> This is related to jute.maxbuffer problems on the server side when Leader 
> generates a proposal that doesn't fit into Follower's Jute buffer causing the 
> quorum to be broken.
> Proposed solution is to add the following new JMX Beans:
> 1. Add getJuteMaxBuffer to ZookeeperServerBean which monitors the current 
> jute.maxbuffer setting,
> 2. Add get last/min/max ProposalSize to LeaderBean which monitors the size of 
> the latest/min/max proposal.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Reply via email to