[
https://issues.apache.org/jira/browse/ZOOKEEPER-2849?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16257779#comment-16257779
]
Hadoop QA commented on ZOOKEEPER-2849:
--------------------------------------
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 16 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
-1 javac. The patch appears to cause tar ant target to fail.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1267//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1267//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1267//console
This message is automatically generated.
> Quorum port binding needs exponential back-off retry
> ----------------------------------------------------
>
> Key: ZOOKEEPER-2849
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2849
> Project: ZooKeeper
> Issue Type: Improvement
> Components: quorum
> Affects Versions: 3.4.6, 3.5.3
> Reporter: Brian Lininger
> Assignee: Brian Lininger
> Priority: Minor
>
> Recently we upgraded the AWS instance type we use for running out ZooKeeper
> nodes, and by doing so we're intermittently hitting an issue where ZooKeeper
> cannot bind to the server election port because the IP is incorrect. This is
> due to name resolution in Route53 not being in sync when ZooKeeper starts on
> the more powerful EC2 instances. Currently in QuorumCnxManager.Listener, we
> only attempt to bind 3 times with a 1s sleep between retries, which is not
> long enough.
> I'm proposing to change this to follow an exponential back-off type strategy
> where each failed attempt causes a longer sleep between retry attempts. This
> would allow for Zookeeper to gracefully recover when the host is
> misconfigured, and subsequently corrected, without requiring the process to
> be restarted while also minimizing the impact to the running instance.
--
This message was sent by Atlassian JIRA
(v6.4.14#64029)
