Github user afine commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/423#discussion_r153658262
  
    --- Diff: src/java/main/org/apache/zookeeper/ClientCnxnSocketNetty.java ---
    @@ -340,13 +340,24 @@ public static Packet getInstance() {
                 return instance;
             }
         }
    +
         /**
          * ZKClientPipelineFactory is the netty pipeline factory for this netty
          * connection implementation.
          */
         private class ZKClientPipelineFactory implements 
ChannelPipelineFactory {
             private SSLContext sslContext = null;
             private SSLEngine sslEngine = null;
    +        private String host;
    +        private int port;
    +
    +        public ZKClientPipelineFactory() {
    --- End diff --
    
    do we still need this constructor?


---

Reply via email to