Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/447#discussion_r160971106
--- Diff: src/java/main/org/apache/zookeeper/server/SessionTrackerImpl.java
---
@@ -280,6 +278,12 @@ public synchronized boolean addSession(long id, int
sessionTimeout) {
return added;
}
+ public synchronized boolean commitSession(long id, int sessionTimeout)
{
--- End diff --
`sessionsWithTimeout` is a Map within ZKdb, so adding sessions to it is
equivalent to persisting them.
I think you could also remove the `addGlobalSession()` method completely,
because it doesn't do anything special than forwarding the call to
`addSession()`.
---
