Github user afine commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/443#discussion_r163377320
--- Diff: build.xml ---
@@ -124,6 +160,7 @@ xmlns:cs="antlib:com.puppycrawl.tools.checkstyle.ant">
<property name="ivy.javacc.lib" value="${build.dir}/javacc/lib"/>
<property name="ivy.releaseaudit.lib"
value="${build.dir}/releaseaudit/lib"/>
<property name="ivy.owasp.lib" value="${build.dir}/owasp/lib"/>
+ <property name="ivy.coverage.lib" value="${test.java.build.dir}/lib"/>
--- End diff --
My concern here is around classpath issues. Ideally I would like to make
sure that clover and its dependencies (my understanding is that there are none
currently but this could change) are only included when we are instrumenting
coverage. The given setup may see us including clover in the test classpath
even when not intended. For example, a developer wants to run the tests with
clover and then immediately after without. If my understanding is correct, it
there is no `clean` before those two executions clover will be included in the
classpath of the second.
---
