Github user eolivelli commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/457#discussion_r168302735
--- Diff:
src/java/main/org/apache/zookeeper/client/ZooKeeperSaslClient.java ---
@@ -310,6 +313,9 @@ public void respondToServer(byte[] serverToken,
ClientCnxn cnxn) {
// TODO: introspect about runtime environment (such as
jaas.conf)
saslState = SaslState.FAILED;
throw new SaslException("Error in authenticating with a
Zookeeper Quorum member: the quorum member's saslToken is null.");
+ } else if (new String(saslToken).equals(AUTHENTICATION_FAILED)) {
--- End diff --
Not setting an explicit charset is a code smell, in this case we are using
only chars so it won't be a gread deal, but it is better ti have clean code
---
