Github user anmolnar commented on the issue:

    https://github.com/apache/zookeeper/pull/474
  
    @sumitagrawl Thanks for opening this pull request and thanks for the 
contribution.
    This stuff with the test looks good to me.
    Given that this is a fix in base class (ServerCnxn) rather than the NIO 
implementation, have you considered adding similar test to Netty as well?
    It might be even better to have a separate test file for the common code, 
so we don't have to replicate tests every time we test something in here.
    What do you think?


---

Reply via email to