[
https://issues.apache.org/jira/browse/ZOOKEEPER-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16393625#comment-16393625
]
ASF GitHub Bot commented on ZOOKEEPER-2999:
-------------------------------------------
GitHub user andschwa opened a pull request:
https://github.com/apache/zookeeper/pull/486
ZOOKEEPER-2999: CMake build should use target-level commands
CMake is using `include_directories`, which has global side effects,
instead of the more explicit `target_include_directories`, to include
directories per target (and with private or public scoping).
Furthermore, CMake should also use `CMAKE_CURRENT_SOURCE_DIR` over
`CMAKE_SOURCE_DIR` in order to allow inclusion in other projects via
`add_subdirectory()`, and we can reduce the minimally required CMake
version to 3.5 from 3.6.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/andschwa/zookeeper ZOOKEEPER-2999
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/zookeeper/pull/486.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #486
----
commit 5e184a2b56561af012a09d395e687a0a2cf3cf42
Author: proller <proller@...>
Date: 2017-09-28T14:40:38Z
ZOOKEEPER-2999: CMake build should use target-level commands
CMake is using `include_directories`, which has global side effects,
instead of the more explicit `target_include_directories`, to include
directories per target (and with private or public scoping).
Furthermore, CMake should also use `CMAKE_CURRENT_SOURCE_DIR` over
`CMAKE_SOURCE_DIR` in order to allow inclusion in other projects via
`add_subdirectory()`, and we can reduce the minimally required CMake
version to 3.5 from 3.6.
----
> CMake build should use target-level commands
> --------------------------------------------
>
> Key: ZOOKEEPER-2999
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2999
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.6.0
> Reporter: Andrew Schwartzmeyer
> Assignee: Andrew Schwartzmeyer
> Priority: Minor
>
> Originally suggested in [GitHub PR
> #386|https://github.com/apache/zookeeper/pull/386], the CMake build I wrote
> used {{include_directories}}, which has global side effects, instead of the
> more explicit {{target_include_directories}}, to include directories per
> target (and with private or public scoping).
> Furthermore, it should also use {{CMAKE_CURRENT_SOURCE_DIR}} over
> {{CMAKE_SOURCE_DIR}} in order to allow inclusion in other projects via
> {{add_subdirectory()}}, and we can reduce the minimally required CMake
> version to 3.5 from 3.6.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
