[
https://issues.apache.org/jira/browse/ZOOKEEPER-2999?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16432318#comment-16432318
]
ASF GitHub Bot commented on ZOOKEEPER-2999:
-------------------------------------------
Github user anmolnar commented on the issue:
https://github.com/apache/zookeeper/pull/486
@andschwa I always get confused with these cpp unit tests. They're flaky
for sure, but can't really tell why.
I tested your changes and was able to build the client successfully with
CMake. I've also run the tests multiple times on Docker and Virtualbox
(centos7) and got test failed in `testAsyncMulti()` and `testReadOnly()` and
also successful runs.
You might want to take a closer look at C++ tests why they're failing - I
suspect you have massive experience - or just keep trying to trigger builds for
a green run.
> CMake build should use target-level commands
> --------------------------------------------
>
> Key: ZOOKEEPER-2999
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2999
> Project: ZooKeeper
> Issue Type: Improvement
> Affects Versions: 3.6.0
> Reporter: Andrew Schwartzmeyer
> Assignee: Andrew Schwartzmeyer
> Priority: Minor
>
> Originally suggested in [GitHub PR
> #386|https://github.com/apache/zookeeper/pull/386], the CMake build I wrote
> used {{include_directories}}, which has global side effects, instead of the
> more explicit {{target_include_directories}}, to include directories per
> target (and with private or public scoping).
> Furthermore, it should also use {{CMAKE_CURRENT_SOURCE_DIR}} over
> {{CMAKE_SOURCE_DIR}} in order to allow inclusion in other projects via
> {{add_subdirectory()}}, and we can reduce the minimally required CMake
> version to 3.5 from 3.6.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
