[GitHub] zookeeper pull request #500: ZOOKEEPER-2959: ignore accepted epoch and LEADE...

[lavacat]

Github user lavacat commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/500#discussion_r182889043
  
    --- Diff: src/java/main/org/apache/zookeeper/server/quorum/Leader.java ---
    @@ -900,9 +902,10 @@ public long getEpochToPropose(long sid, long 
lastAcceptedEpoch) throws Interrupt
                 return epoch;
             }
         }
    -
    -    private HashSet<Long> electingFollowers = new HashSet<Long>();
    -    private boolean electionFinished = false;
    +    // VisibleForTesting
    +    protected HashSet<Long> electingFollowers = new HashSet<Long>();
    --- End diff --
    
    Can't use Set, because QuorumVerifier uses HashSet param. 
    QuorumVerifier.containsQuorum(HashSet<Long> set);
    
    I can refactor it all, but then I'll need to touch QuorumVerifier.java, 
QuorumMaj.java and QuorumHierarchical.java


---