[ 
https://issues.apache.org/jira/browse/ZOOKEEPER-2940?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16449031#comment-16449031
 ] 

ASF GitHub Bot commented on ZOOKEEPER-2940:
-------------------------------------------

Github user phunt commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/466#discussion_r183565848
  
    --- Diff: src/contrib/monitoring/ganglia/zookeeper_ganglia.py ---
    @@ -213,7 +213,13 @@ def metric_init(params=None):
             'zk_max_file_descriptor_count': {'units': 'descriptors'},
             'zk_followers': {'units': 'nodes'},
             'zk_synced_followers': {'units': 'nodes'},
    -        'zk_pending_syncs': {'units': 'syncs'}
    +        'zk_pending_syncs': {'units': 'syncs'},
    +        'zk_last_proposal_size': {'units': 'ms'},
    --- End diff --
    
    Should these values be in "ms"? Seems like a cut/paste typo? I suspect you 
rather "bytes" - right?


> Deal with maxbuffer as it relates to large requests from clients
> ----------------------------------------------------------------
>
>                 Key: ZOOKEEPER-2940
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2940
>             Project: ZooKeeper
>          Issue Type: Sub-task
>          Components: jute, server
>            Reporter: Andor Molnar
>            Assignee: Andor Molnar
>            Priority: Major
>             Fix For: 3.5.4, 3.6.0
>
>
> Monitor real-time Jute buffer usage as it relates to large requests from 
> clients.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

Reply via email to