[jira] [Commented] (ZOOKEEPER-3019) Add a metric to track number of slow fsyncs

[ASF GitHub Bot (JIRA)]

    [ 
https://issues.apache.org/jira/browse/ZOOKEEPER-3019?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16456273#comment-16456273
 ] 

ASF GitHub Bot commented on ZOOKEEPER-3019:
-------------------------------------------

Github user nkalmar commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/501#discussion_r184667238
  
    --- Diff: src/contrib/monitoring/check_zookeeper.py ---
    @@ -256,6 +261,36 @@ def _parse_stat(self, data):
                     result['zk_znode_count'] = int(m.group(1))
                     continue
     
    +            m = re.match('Watch count: (\d+)', line)
    +            if m is not None:
    +                result['zk_watch_count'] = int(m.group(1))
    +                continue
    +
    +            m = re.match('Ephemerals count: (\d+)', line)
    +            if m is not None:
    +                result['zk_ephemerals_count'] = int(m.group(1))
    +                continue
    +
    +            m = re.match('Approximate data size: (\d+)', line)
    +            if m is not None:
    +                result['zk_approximate_data_size'] = int(m.group(1))
    +                continue
    +
    +            m = re.match('Open file descriptor count: (\d+)', line)
    +            if m is not None:
    +                result['zk_open_file_descriptor_count'] = int(m.group(1))
    +                continue
    +
    +            m = re.match('Max file descriptor count: (\d+)', line)
    +            if m is not None:
    +                result['zk_max_file_descriptor_count'] = int(m.group(1))
    +                continue
    +
    +            m = re.match('Fsync threshold exceeded: (\d+)', line)
    --- End diff --
    
    Yes, thats for stat command, thanks. I changed it and tested the py 
scripts, looks good now.


> Add a metric to track number of slow fsyncs
> -------------------------------------------
>
>                 Key: ZOOKEEPER-3019
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3019
>             Project: ZooKeeper
>          Issue Type: Improvement
>          Components: jmx, server
>    Affects Versions: 3.5.3, 3.4.11, 3.6.0
>            Reporter: Norbert Kalmar
>            Assignee: Norbert Kalmar
>            Priority: Major
>             Fix For: 3.5.4, 3.6.0, 3.4.13
>
>
> Add jmx bean and Command to ZooKeeper server to expose the the number of slow 
> fsyncs as a metric.
> FileTxnLog.commit() should count the number of times fsync exceeds 
> fsyncWarningThresholdMS.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)