[ https://issues.apache.org/jira/browse/ZOOKEEPER-645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16466098#comment-16466098 ]
Edward Capriolo edited comment on ZOOKEEPER-645 at 5/7/18 4:27 PM: ------------------------------------------------------------------- I am going to suggest removing the code. It seems clear that # The implementation has bugs # Willingness to fix them is near 0 # The implementation is not even a good academic example # If anyone attempts to fix it gets stalled by adding integration testing that is not in place # There are other mature lock over zk libraries in the wild was (Author: appodictic): I am going to suggest removing the code. It seems clear that # The implementation has bugs # Willingness to fix them is near 0 # The implementation is not even a good academic example # If anyone attempts to fix it gets stalled by adding integration testing that is not in place > Bug in WriteLock recipe implementation? > --------------------------------------- > > Key: ZOOKEEPER-645 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-645 > Project: ZooKeeper > Issue Type: Bug > Components: recipes > Affects Versions: 3.2.2 > Environment: 3.2.2 java 1.6.0_12 > Reporter: Jaakko Laine > Assignee: Mahadev konar > Priority: Minor > Fix For: 3.6.0 > > Attachments: 645-fix-findPrefixInChildren.patch, > ZOOKEEPER-645-compareTo.patch, ZOOKEEPER-645.3.patch.txt > > > Not sure, but there seem to be two issues in the example WriteLock: > (1) ZNodeName is sorted according to session ID first, and then according to > znode sequence number. This might cause starvation as lower session IDs > always get priority. WriteLock is not thread-safe in the first place, so > having session ID involved in compare operation does not seem to make sense. > (2) if findPrefixInChildren finds previous ID, it should add dir in front of > the ID -- This message was sent by Atlassian JIRA (v7.6.3#76005)