[
https://issues.apache.org/jira/browse/ZOOKEEPER-3038?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16469641#comment-16469641
]
Hadoop QA commented on ZOOKEEPER-3038:
--------------------------------------
-1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 3 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1668//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1668//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1668//console
This message is automatically generated.
> Cleanup some nitpicks in TTL implementation
> -------------------------------------------
>
> Key: ZOOKEEPER-3038
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3038
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.5.3
> Reporter: Andor Molnar
> Assignee: Andor Molnar
> Priority: Major
>
> A few nitpicks which needs to be cleaned up:
> 1. Rename OldEphemeralType --> EphemeralTypeEmulate353
> 2. Remove unused method: getTTL()
> 3. Remove unused import from QuorumPeer
>
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
