[
https://issues.apache.org/jira/browse/ZOOKEEPER-2492?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16471075#comment-16471075
]
Hadoop QA commented on ZOOKEEPER-2492:
--------------------------------------
-1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12820929/ZOOKEEPER-2492.patch
against trunk revision 2fa315b7d0ed65828479fcdcc9e76ca8552fba4a.
+1 @author. The patch does not contain any @author tags.
-1 tests included. The patch doesn't appear to include any new or modified
tests.
Please justify why no new tests are needed for this
patch.
Also please list what manual steps were performed to
verify this patch.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
-1 core tests. The patch failed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3667//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3667//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/3667//console
This message is automatically generated.
> gethostname return error before Win32WSAStartup on windows.
> -----------------------------------------------------------
>
> Key: ZOOKEEPER-2492
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-2492
> Project: ZooKeeper
> Issue Type: Bug
> Affects Versions: 3.5.2
> Environment: windows
> Reporter: spooky000
> Assignee: spooky000
> Priority: Trivial
> Fix For: 3.6.0, 3.5.5
>
> Attachments: ZOOKEEPER-2492.patch, ZOOKEEPER-2492.patch,
> ZOOKEEPER-2492.patch
>
>
> gethostname return error before Win32WSAStartup on windows.
> in log_env function.
> gethostname(buf, sizeof(buf));
> LOG_INFO(LOGCALLBACK(zh), "Client environment:host.name=%s", buf);
> buf will be uninitialized buffer.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
