Github user nkalmar commented on the issue: https://github.com/apache/zookeeper/pull/533 I agree with @anmolnar in that the methods are a little robust and test multiple things. Whether it should be refactored whenever we touch a unit test, that's a tough question. But I also agree with what @maoling said about the inner class: generally, unit tests should not be separated when dealing with inner classes, as they only makes sense in the context of the outer class. Anyway, the change looks good to me!
---