[
https://issues.apache.org/jira/browse/ZOOKEEPER-3058?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16506269#comment-16506269
]
Hadoop QA commented on ZOOKEEPER-3058:
--------------------------------------
+1 overall. GitHub Pull Request Build
+1 @author. The patch does not contain any @author tags.
+0 tests included. The patch appears to be a documentation patch that
doesn't require tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac
compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1)
warnings.
+1 release audit. The applied patch does not increase the total number of
release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1820//testReport/
Findbugs warnings:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1820//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output:
https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1820//console
This message is automatically generated.
> Do length check first before actual byte check in compareBytes method of
> Utils class
> ------------------------------------------------------------------------------------
>
> Key: ZOOKEEPER-3058
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3058
> Project: ZooKeeper
> Issue Type: Improvement
> Components: jute
> Reporter: Hosur Narahari
> Priority: Minor
> Labels: pull-request-available
> Time Spent: 10m
> Remaining Estimate: 0h
>
> In compareBytes method of org.apache.jute.Utils class, all the individual
> bytes of 2 byte arrays are compared and then their lengths are compared. We
> can improve the performance by first having length check, since we can rule
> out that they aren't equal by a single if condition(O(1) operation) rather
> than looping through arrays(O( n ) operation).
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)
