Github user timothyjward commented on the issue:

    https://github.com/apache/zookeeper/pull/529
  
    > * why have you created the patch against branch-3.5? jira is targeted to 
trunk too, don't you want to merge it to that branch?
    
    I work against the 3.5 release branch, which is how I maintain my fork. I 
created the PR against 3.5 because that's the commit I already had, and the 
3.5.x stream is the version I would like to see fixed. I assumed the fix would 
then be cherry-picked onto trunk (which is what seems to happen with the other 
PRs). 
    
    There's no way that I know of to change the target branch of a PR after it 
has been created, so unless you need me to close this PR and create a new one 
I'll continue targeting the 3.5 branch.
    
    > * please fix indentation in both files
    
    Will do - I'll squash the commits too to avoid the risk of it ending up in 
history


---

Reply via email to