Github user dain commented on a diff in the pull request:

    https://github.com/apache/zookeeper/pull/184#discussion_r195534358
  
    --- Diff: src/java/main/org/apache/zookeeper/common/X509Util.java ---
    @@ -79,7 +91,7 @@
         public X509Util() {
             String cipherSuitesInput = 
System.getProperty(cipherSuitesProperty);
             if (cipherSuitesInput == null) {
    -            cipherSuites = null;
    +            cipherSuites = getDefaultCipherSuites();
    --- End diff --
    
    I would say that if a user manually selected a cipher suite and it is not 
present on the JVM it should be an error.  Otherwise they are not getting what 
they explicitly asked for.  That said, I'm not sure you can check this 
explicitly (I don't know the apis that well either... especially when multiple 
providers are installed).


---

Reply via email to