Github user anmolnar commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/546#discussion_r197395687
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/RemotePeerBeanTest.java ---
@@ -36,7 +36,7 @@ public void
testGetClientAddressShouldReturnEmptyStringWhenClientAddressIsNull()
InetSocketAddress peerCommunicationAddress = null;
// Here peerCommunicationAddress is null, also clientAddr is null
QuorumServer peer = new QuorumServer(1, peerCommunicationAddress);
- RemotePeerBean remotePeerBean = new RemotePeerBean(peer);
+ RemotePeerBean remotePeerBean = new RemotePeerBean(null
/*QuorumPeer*/, peer);
--- End diff --
Do you think that comment could be useful? Modern IDEs like intellij give
hints about null arguments and the comment seems to be redundant to me.
---
