[ https://issues.apache.org/jira/browse/ZOOKEEPER-3059?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16521088#comment-16521088 ]
Hadoop QA commented on ZOOKEEPER-3059: -------------------------------------- +1 overall. GitHub Pull Request Build +1 @author. The patch does not contain any @author tags. +1 tests included. The patch appears to include 3 new or modified tests. +1 javadoc. The javadoc tool did not generate any warning messages. +1 javac. The applied patch does not increase the total number of javac compiler warnings. +1 findbugs. The patch does not introduce any new Findbugs (version 3.0.1) warnings. +1 release audit. The applied patch does not increase the total number of release audit warnings. +1 core tests. The patch passed core unit tests. +1 contrib tests. The patch passed contrib unit tests. Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1860//testReport/ Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1860//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-github-pr-build/1860//console This message is automatically generated. > EventThread leak in case of Sasl AuthFailed > ------------------------------------------- > > Key: ZOOKEEPER-3059 > URL: https://issues.apache.org/jira/browse/ZOOKEEPER-3059 > Project: ZooKeeper > Issue Type: Bug > Affects Versions: 3.4.12 > Reporter: Abhishek Singh Chouhan > Assignee: Abhishek Singh Chouhan > Priority: Critical > Labels: pull-request-available > Attachments: stack_dump > > Time Spent: 1h 40m > Remaining Estimate: 0h > > In case of an authFailed sasl event we shutdown the send thread however we > never close the event thread. Even if the client tries to close the > connection it results in a no-op since we check for cnxn.getState().isAlive() > which results in negative for auth failed state and we return without > cleaning up. For applications that retry in case of auth failed by closing > the existing connection and then trying to reconnect(eg. hbase replication) > this eventually ends up exhausting the system resources. -- This message was sent by Atlassian JIRA (v7.6.3#76005)