Github user ivankelly commented on a diff in the pull request:
https://github.com/apache/zookeeper/pull/546#discussion_r197768450
--- Diff:
src/java/test/org/apache/zookeeper/server/quorum/RemotePeerBeanTest.java ---
@@ -36,7 +36,7 @@ public void
testGetClientAddressShouldReturnEmptyStringWhenClientAddressIsNull()
InetSocketAddress peerCommunicationAddress = null;
// Here peerCommunicationAddress is null, also clientAddr is null
QuorumServer peer = new QuorumServer(1, peerCommunicationAddress);
- RemotePeerBean remotePeerBean = new RemotePeerBean(peer);
+ RemotePeerBean remotePeerBean = new RemotePeerBean(null
/*QuorumPeer*/, peer);
--- End diff --
Not everyone uses an IDE, and code review happens on github which doesn't
give hints about this stuff.
---
